fix: Mark WindowsExec as incompatible
#2748
Open
+308
−306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Nov 9, 2025
| case _: CollectLimitExec => true | ||
| case _: UnionExec => true | ||
| case _: TakeOrderedAndProjectExec => true | ||
| case _: WindowExec => true |
Member
Author
There was a problem hiding this comment.
Removing this line fixes #2737. I wish I could explain why, but I cannot.
Contributor
There was a problem hiding this comment.
WindowExec was added here because it was related to TakeOrderedProjectExec which was added here previuosly, but you are right, it is most likely the reason, why the operator doesn't fallback to Spark in clean way
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
============================================
+ Coverage 56.12% 58.73% +2.60%
- Complexity 976 1465 +489
============================================
Files 119 163 +44
Lines 11743 13984 +2241
Branches 2251 2375 +124
============================================
+ Hits 6591 8213 +1622
- Misses 4012 4567 +555
- Partials 1140 1204 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
WindowsExec as incompatibleWindowsExec as incompatible [WIP]
andygrove
changed the title
WindowsExec as incompatible [WIP]WindowsExec as incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follows on from #2741
Rationale for this change
Remove temp fallback and use
CometOperatorSerdeframework insteadWhat changes are included in this PR?
CometOperatorSerdeframework insteadWindowsExecas a Comet sink because it causes panicsHow are these changes tested?